Responsive full view #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKOLZ
suggested changes
Sep 21, 2017
README.md
Outdated
| @@ -100,29 +102,13 @@ class App extends Component { | |||
| export default App; | |||
| ``` | |||
|
|
|||
| 4- Customize the widget to match your app design! You can add both props to manage the title of the widget, the avatar it will use and of course the styles it will have. | |||
| 4- Customize the widget to match your app design! You can add both props to manage the title of the widget, the avatar it will use and of course, you can change, from the CSS, the styles the widget will have. | |||
There was a problem hiding this comment.
there are a lot of commas at the end of this sentence, check how to paraphrase it with iniaki
README.md
Outdated
| - **stylesInjected:** (Proptypes.object) The styles to be injected, see [styles](#styles) | ||
| - **handleNewUserMessage:** (PropTypes.func.isRequired) Function to handle the user input, will receive the full text message when submitted | ||
| - **profileAvatar:** (PropTypes.string) The profile image that will be set on the responses | ||
| - **showCloseButton:** (PropTypes.bool) Show or not the close button in full screen mode |
| <div className="header"> | ||
| {showCloseButton && |
There was a problem hiding this comment.
Mmm.. I don't really like the way it looks writing in a separate line and leaving the { alone 😞
| <div className="header"> | ||
| {showCloseButton && | ||
| <button className="close-button" onClick={toggleChat}> | ||
| <img src={close} className="close" alt="" /> |
| flex-direction: column; | ||
| height: 100%; | ||
| } | ||
| } |
SKOLZ
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add full screen in responsive mobile view
Screenshot
Landscape: